Improve ellipse related functions

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Improve ellipse related functions

dxli
This post was updated on .
Hello,

The current ellipse functions (like trim/extend) do not work properly, I want to help clean it up.

I have opened my first pull request #106
Reply | Threaded
Open this post in threaded view
|

Re: Improve ellipse related functions

R. van Twisk
Administrator
Hey,

all help is very much welcomed!
I have applied your patch.

Ries


On Jul 22, 2011, at 7:48 AM, dxli [via LibreCAD] wrote:

Hello,

The current ellipse functions (like trim/extend) does work properly, I want to help clean it up.

I have opened my first pull request #106


If you reply to this email, your message will be added to the discussion below:
http://librecad.1049103.n5.nabble.com/Improve-ellipse-related-functions-tp4622888p4622888.html
To start a new topic under LibreCAD, email [hidden email]
To unsubscribe from LibreCAD, click here.

Reply | Threaded
Open this post in threaded view
|

Re: Improve ellipse related functions

dxli
Thanks! I will try to clean up more.

While being a qcad user years ago, I noticed that geometry functions for ellipses (and other curves beyond circles) were not properly implemented. I'm glad that I can improve the math part thanks to your LibreCAD setup.
Reply | Threaded
Open this post in threaded view
|

Re: Improve ellipse related functions

R. van Twisk
Administrator

On Jul 22, 2011, at 9:38 AM, dxli [via LibreCAD] wrote:

Thanks! I will try to clean up more.

While being a qcad user years ago, I noticed that geometry functions for ellipses (and other curves beyond circles) were not properly implemented. I'm glad that I can improve the math part thanks to your LibreCAD setup.

We are glad you can help out! ;)

I just tested it here locally, and it works fine...

On the ellipse, circle I hope to have drawing improved also and grid of LibreCAD
create line segments and use the 'native' drawing capabilities of Qt to draw
circles and ellipses.

happy hacking, and again thanks!

Ries





If you reply to this email, your message will be added to the discussion below:
http://librecad.1049103.n5.nabble.com/Improve-ellipse-related-functions-tp4622888p4623383.html
To start a new topic under LibreCAD, email [hidden email]
To unsubscribe from LibreCAD, click here.