LibreCAD › LibreCAD-dev

libdxfrw issue

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

dxli

libdxfrw issue

Hi Rallaz,

I am looking into compiler warnings:

at line 379 of drw_entities.cpp:

    if(space == 2){//entity are in block
        dwgHandle ownerH = buf->getOffsetHandle(handle);
        DRW_DBG("owner (parent) Handle: "); DRW_DBGHL(ownerH.code, ownerH.size, ownerH.ref); DRW_DBG("\n");
        DRW_DBG("   Remaining bytes: "); DRW_DBG(buf->numRemainingBytes()); DRW_DBG("\n");
        parentHandle = ownerH.ref;
        DRW_DBG("Block (parent) Handle: "); DRW_DBGHL(ownerH.code, ownerH.size, parentHandle); DRW_DBG("\n");
    }

but

//! Spaces
enum Space {
    ModelSpace = 0,
    PaperSpace = 1
};

Thanks!

Rallaz

Re: libdxfrw issue

enum Space was written initially for dxf format, code 67, and can be:

0 = model sapace or
1 = paper space

But adding dwg suport:

0 = entity are part of a block or old style (R12) polyline
1 = paper space
2 = model sapace

the 0 option in dwg must be hide

Added a patch in master branch

Cheers,
Rallaz