Authorization for another patch needed.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Authorization for another patch needed.

ClaudeQC
Ries,

I am in the process of patching tracker bug #3369516 (Line Width scaling bug on print preview).
https://sourceforge.net/tracker/?func=detail&aid=3369516&group_id=342582&atid=1433844

This is the second patch applied to "rs_graphicview.cpp".
So, the patch I am doing now will also do the modification found the older patch, indicated below:
Patch #3376517 (Patch that fix bug #3376515 (Absolute zero reference bug))
https://sourceforge.net/tracker/?func=detail&aid=3376517&group_id=342582&atid=1433846
Notes: This patch seems to not be applied, even if you said that it was applied in the tracker !?

Is that Ok for creating the patch now ?
Or do I have to wait you to (re-)apply the first (older) patch ?

Claude


Reply | Threaded
Open this post in threaded view
|

Re: Authorization for another patch needed.

R. van Twisk
Administrator
Claude,

I tend to commit my patches for on the upcomming RC2 and do some work during the day...
Then I merge into master and commit to github.

And, I actually (2 minutes ago) all mentioned fixes are on github.


Ries

On Jul 24, 2011, at 2:18 PM, ClaudeQC [via LibreCAD] wrote:

Ries,

I am in the process of patching tracker bug #3369516 (Line Width scaling bug on print preview).
https://sourceforge.net/tracker/?func=detail&aid=3369516&group_id=342582&atid=1433844

This is the second patch applied to "rs_graphicview.cpp".
So, the patch I am doing now will also do the modification found the older patch, indicated below:
Patch #3376517 (Patch that fix bug #3376515 (Absolute zero reference bug))
https://sourceforge.net/tracker/?func=detail&aid=3376517&group_id=342582&atid=1433846
Notes: This patch seems to not be applied, even if you said that it was applied in the tracker !?

Is that Ok for creating the patch now ?
Or do I have to wait you to (re-)apply the first (older) patch ?

Claude





If you reply to this email, your message will be added to the discussion below:
http://librecad.1049103.n5.nabble.com/Authorization-for-another-patch-needed-tp4628590p4628590.html
To start a new topic under LibreCAD, email [hidden email]
To unsubscribe from LibreCAD, click here.

Reply | Threaded
Open this post in threaded view
|

Re: Authorization for another patch needed.

ClaudeQC

On 24/07/2011 15:33, R. van Twisk [via LibreCAD] wrote:

 >
 > I tend to commit my patches for on the upcomming RC2 and do some work during
 > the day...
 > Then I merge into master and commit to github.
 >
 > And, I actually (2 minutes ago) all mentioned fixes are on github.
 >
 > Here is it located :
 >
https://github.com/LibreCAD/LibreCAD/commit/9d362ec5fbfd730caef233567355d95f32585c85
 >
 > Ries
 >

- Ok.  I understand now.

- I have probably get LibreCAD from GIT too early (before you have
   applied the patch).

- I just get LibreCAD from GIT now, and I see that patches have been applied.


Claude