LibreCAD-2.1.3 - Mods to allow clean compile & run with Qt 5.8 - gcc/g++

Hello,

"std::auto" is depreciated and should be replaced with "std::unique".

If you change the following:-

LibreCAD-2.1.3\libraries\muparser\include\muParserToken.h
about line 72
      //*** ***
      //std::auto_ptr<ParserCallback> m_pCallback;
      std::unique_ptr<ParserCallback> m_pCallback;
      //*** ***

LibreCAD-2.1.3\libraries\muparser\include\muParserBase.h
about line 292
    //*** ***
    //std::auto_ptr<token_reader_type> m_pTokenReader; ///< Managed pointer to the token reader object.
    std::unique_ptr<token_reader_type> m_pTokenReader; ///< Managed pointer to the token reader object.
    //*** ***

LibreCAD-2.1.3\librecad\src\custom.pro
add
BOOST_DIR = "C:/boost/boost_1_63_0.7/"
BOOST_LIBDIR = "C:/boost/boost_1_63_0.7/libs/"


Windows 10 - 32 bit
You can get a clean compile and run from within Qt Creator 4.3.0 / Qt 5.8.0 using mingw53_32 - gcc/g++.
I've got Microsoft Visual Studio 2017 installled and setup but I'm not using it, you need MSVS in your path.
I'm using Boost_1_63_0.7

My path as an example (all one line) :-
PATH=C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;
C:\Program Files\Windows Live\Shared;C:\Qt\Tools\mingw530_32\bin;
C:\Program Files\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\bin\HostX86\x86;
C:\Users\Michael\AppData\Local\Microsoft\WindowsApps

Regards

Where these changes also tested on OS/X and Linux?

Can yuo send a a pull request?
This will make it by far easer for us to test on different platforms.

Ries

Hello,

"std::unique" is used elsewhere in the Librecad source.
So I think changing from "std::auto" will not be platform dependent.

I don't know how to make a pull request.

Regards

I'm still watching this for a while now.

As muparser is an external library, I didn't touch this so far. I'd prefer to have this solved in muparser and then update the muparser source in our lib path to stay synced.

There is already an issue opened in the main muparser repo on github. I consider to make a pull request there.


To make a pull request, you need a github account.
Fork the project you want to contribute to.
Commit changes to a new branch in your fork repo and sync it with github.
Then it's easy to open a new pull request on the upstream repo.

This is explained in detail on github help pages.
If you don't have an account now, consider to register one, contributing is much easier then.


Thanks anyway for your efforts.

Armin