Developer branch

Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Developer branch

emanuel
Reply | Threaded
Open this post in threaded view
|

Re: Developer branch

dxli
Do you think it's stable enough for merging?

emanuel wrote
Reply | Threaded
Open this post in threaded view
|

Re: Developer branch

sand1024
hm... I suppose the content there requires some additional review and refactoring...
Reply | Threaded
Open this post in threaded view
|

Re: Developer branch

emanuel
all actions go well
Reply | Threaded
Open this post in threaded view
|

Re: Developer branch

sand1024
so far I can't even build that branch that I've just pull from Git.

First, I've tried to build it with CMake.

Ok, I've managed to install swig and set proper variables in CMakeLists.txt (yet that's not good that they are not there by default in CMakeLists.txt, I suppose).

But later, when building the project, the build process is failed with message:

[735/766] Linking CXX static library librecad_lib.lib
[736/766] Swig compile librecad/src/python.i for python
FAILED: [code=1] CMakeFiles/librepython.dir/pythonPYTHON_wrap.cxx librecad.py D:/Local/LibreCAD_Developer/cmake-build-debug/CMakeFiles/librepython.dir/pythonPYTHON_wrap.cxx D:/Local/LibreCAD_Developer/cmake-build-debug/librecad.py
CMakeFiles\pythonPYTHON_wrap.cxx-f79fbc4.bat 976b77978b0cec99
Language subdirectory: python
Search paths:
......
......
......
Preprocessing...
(999999) : Error: Unable to find 'swig.swg'
(2) : Error: Unable to find 'python.swg'
D:\Local\LibreCAD_Developer\librecad\src\python.i(16) : Error: Unable to find 'std_string.i'
Batch file failed at line 4 with errorcode 1

So after that I've switched to QtCreator and opened the project there.

In QtCreator project:
1) src/slide_records_visitor_qt_drawer.hpp file seems to be missing (referred by libslide.pro)

Probably I'll manage to correct QtCreator project to get some buildable state, but try to check this later.

Also, I'm not sure that some samples (both for python and lisp), tests or docs are included into this branch.

So far I didn't review the code - yet it I'll have more time, I'll be happy to drop a couple of notes.