Icon wanted

I just made a pull request for a patch that allows to change direction of lines and arcs (i.e. the start point becomes the end point and vice versa).

Is there someone who can create a menu icon for that action? I am totally hopeless when it comes to graphics ;-).

Best regards,
Robert

Well it's not that complicated.
Just fire up your M$ Paint and do some magic.
Here is my awesome icon. The R stands for reverse.

Just wanted to add a border to the icon and unfortunately my linux machine does not have M$ Paint.
So I had to use some open source software.
It may look not as good as the icon I posted before but have a look at it.
http://i39.tinypic.com/s42qv5.png

Just tell which one you want to use.
Would be nice if we let Effad decide which one to use cause he wrote the feature ;)

Hi,

my vote goes to:



Armin

I will add the feature to CAD toolbar.

In 2.1, we will simplify the GUI controlling. Actions will be shared by menu, and toolbars. Right now, there are two independent sets, harder to implement and maintain.

Looks like we have a winner.
100% of the votes went to:


So here is the svg file:
http://www.gamefront.com/files/23730840/reverseIcon.zip
ea26496bf00154e4b92eaeeb3065af40  reverseIcon.zip

I sent a pull request to Robert's branch.

Still not sure we should keep Robert's branch as 2.1 fork.

Where is Robert's branch?
Looking at https://github.com/LibreCAD/LibreCAD/branches
I only see 5 Branches and nothing about 2.1.
Sorry I'm not that much into git.

his fork is at:

https://github.com/effad/LibreCAD/

So his repsitory is a fork of LibreCAD 2.0.0 where he works on the CAM feature.
But where is our official 2.1 branch where people can make changes (push? stuff to) ?

I have pulled your changes into my repository, added the icon to the menu and fixed the tooltip in the toolbar.

A pull request to master is open. If I should change it in any way (to a different branch?) please advise.

Best regards,
Robert

Hi,

I tested Robert's HEAD revision and it was OK for me.

But for 2.0, in my mind, we should at least support the reversion of polylines, what has to be implemented first. Of course one can explode, revert and rejoin the polyline. In my eyes this will only be a workaround and a large source for issues and questions.

Next are the circles. A circle is a common shape for milling jobs. LC has no feature to show the direction of a circle. For milling it depends on the spindle rotation, tool and material if the job is done clockwise or counter clockwise.
But one can draw a circle from arcs which can be reverted, so it isn't absolutely needed.

Another question is, if it makes sense to implement reversion for ellipses and splines. From sight of CAM is isn't, because many CNC machines doesn't support this entities. For these cases we need a approximation with tangentially lines and arcs to fit the contour and that are entities which can be reverted.

In general this feature is useful for mechanical drawings to be used with external postprocessors for generating CNC programs from DXF, that is out of the question.

My vision of CAM features track another approach. When getting drawings from friends or customers it shouldn't matter in which directions entities are drawn. Even when drawing yourself, arcs are always draw CCW, but milling in most cases is CW. I don't want to redraw everything to fit the postprocessors needs. I want to show the postprocessor where to start and in which direction the tool should go or where it should stop. To find the path is the job of the postprocessor.  But this is definitely not for 2.0.

I'm afraid that this doesn't simplify the question to merge or not.

Why not start now a branch 2.1 with Robert's features and keep the master until we release 2.0. If there are bug fixes on the master, we can merge them to 2.1. After releasing 2.0 we merge 2.1 into master and start the 2.0 release branch for bug fixes.
This or something like that is the way we handle it in my company. It works very well without much conflicts on merging.

Armin

Making polylines revertible would be my next step. So yes, it is work in progress and should not be considered for 2.0 if that release has been "feature freezed".