Review of command line focusing.

Please review my changes to handle focusing:

https://github.com/LibreCAD/LibreCAD/pull/503

The goal:

1, all keyboard events by the drawing area will be filtered by command line;
2, Enter/Return/Escape would not be touched;
3, other keyboard events should make command line in focus, and keyboard events handled by the command line.

To Review and test: Need to make sure no application shortcut is filtered.

Dongxu,

I've build your repo and did some testing. It behaves different, but still not well.
But I'm not sure, if it's my machine causing the issues. I'll continue tests tomorrow on another PC.

Armin

Hi Armin,

Using event filter could be a solution.

So far, the event filter does give focus to command line.

Enter/Return can be sent to command line and drawing actions. The current code doesn't handle Enter events well.

Ideally, Enter in drawing area should only be sent to drawing actions.

I'm not clear how to preserve applicatoin wide shortcuts, but this part must be done.

LordOfBikes wrote

Dongxu,

I've build your repo and did some testing. It behaves different, but still not well.
But I'm not sure, if it's my machine causing the issues. I'll continue tests tomorrow on another PC.

Armin