Login  Register

Re: Greetings!

Posted by dxli on Mar 30, 2012; 1:50am
URL: https://forum.librecad.org/Greetings-tp5605322p5605494.html

Hi Daniel,

The file save/modified part needs more care. I'm glad about your willing to work on it.

I will apply this patch, and test it. I'm eager to see it main tree soon.

As Ries already mentioned, using git by github.com is the easiest way for us to work together. My own repository at github.com is at,

https://github.com/dxli/LibreCAD

where you can send pull requests for me to test.

Thanks!

Dongxu


On Thu, Mar 29, 2012 at 8:08 PM, [hidden email] [via LibreCAD] <[hidden email]> wrote:
Hello all!
  My name is Daniel and I am looking to contribute to LibreCAD as I can. I was unable to determine how this community handles contributions and was ever hopeful someone could direct me in that matter. Currently I am working off of a fork of master.

As a means for example I have created a patch to fix a slight oddity with the SaveAs dialog. After saving a file to a folder (say folder X), closing the program, reopening the program, the default directory would be the directory above X and the file name would be the name of folder X.

This patch first removes an unnecessary break in the function QG_FileDialog::getExtension

The second part reworks most of the function QG_FileDialog::getSaveFile in order to prevent the above and gives a default name of Untitled (where an incrementing # is added if Untitled already exists)

The patch is attached bellow:
patch.diff



If you reply to this email, your message will be added to the discussion below:
http://forum.librecad.org/Greetings-tp5605322p5605322.html
To start a new topic under LibreCAD-dev, email [hidden email]
To unsubscribe from LibreCAD-dev, click here.
NAML



--
Dongxu Li, Ph.D.
www.librecad.org