Login  Register

Re: preparation for 2.0.6, any blocker?

Posted by dxli on Oct 21, 2014; 2:16pm
URL: https://forum.librecad.org/preparation-for-2-0-6-any-blocker-tp5710555p5710567.html

Thanks for the detailed information.

For trim2 logic, the ideal algorithm should figure out the which portion to trim/keep based on clicking positions. More work is needed, espacially for closed shapes (circles/ellipses).

The crashing by free hand line is due to polyline handling. Polyline is currently handled by its own class of operations, not the generic ones. I disabled polyline for trim2, and hide the the crash:

https://github.com/LibreCAD/LibreCAD/commit/ed332c45ee53263adbb4b36458b03997f140f624

More work is needed to see whether we can enable polyline trim2.

Finally, we will need a better equation solver to handle the tangential 2 point bug.

We need high precision and robust, but it requires a new library most likely. For example:

http://eigen.tuxfamily.org/index.php?title=Main_Page
Quenzo wrote
Hi Dxli

For item 1
steps:
a I draw a circle
b Draw an ellipse intersecting the circle
c Main menu -> Move / Copy
d I make four copies Figs. A, B, C, D and E)
d sign with arrows the exact points where I will select each figure.
e Main menu -> Modify -> Trim / Extend two

In the fig A
First entity to cut: ellipse
Second entity to cut: circle

In the fig B
First entity to cut: ellipse
Second entity to cut: circle

In the fig C
First entity to cut: circle
Second entity to cut: ellipse

In the fig D
First entity to cut: circle
Second entity to cut: ellipse

In the fig E
First entity to cut: ellipse
Second entity to cut: circle

I don't understand why the final results are differents
Trim_two.dxf



For item 2
I did the tests with the option Main Menu -> Modify -> Trim / Extend two, I didn't with the option Main Menu -> Modify -> Divide

steps:
a I draw a circle
b Draw a freehand line intersecting the circle
c Main menu -> Modify -> Trim / Extend two
d First entity to cut: freehand line
e Second entity to cut: circle
f The application closes
(Repeated several times)



For circle tangential and two points
a I draw a square
b Enable snap to middle only
c Main Menu -> circle
d Drawing a circle of radius 10 at the midpoint of the right edge on the square
e Enable snap on endpoints
f Main Menu -> circle -> circle tangential 2 points
g When it asks "Specify the line/arc/circle", I select the circle above
h When it asks "Specify the first point on the circle tangent", I select the lower left corner on the square
i When it asks "Specify the second point on the circle tangent", I select the upper left corner on the square

Result:
Tangential_2points.dxf

Best regards

Manel