Login  Register

Re: libdxfrw build error on Mac

Posted by dxli on Jun 09, 2023; 9:42pm
URL: https://forum.librecad.org/libdxfrw-build-error-on-Mac-tp5722902p5722906.html

It's good to be clear in code though.

For example, we have the same function name parseDWG both overloaded and overrided. It helps to separate them into different names, probably more specific to the purposes of these methods.
LordOfBikes wrote
You can remove -Winconsistent-missing-override from compiler options, if you know how to do this in CMake, then this issue should become a warning, which doesn't stop compilation.
Or you can append the keyword override in drw_objects.h, line 161, that it looks like this:
bool parseDwg(DRW::Version version, dwgBuffer *buf, duint32 bs=0) override;

There maybe other occurrences of this missing override issue.