Re: MTEXT alignment issue 2.2.1_rc2
Posted by
dxli on
May 16, 2024; 7:58pm
URL: https://forum.librecad.org/MTEXT-alignment-issue-2-2-1-rc2-tp5724780p5724785.html
Part of my reasoning is actually already being mentioned by you.
Touching mtext code is never safe;
The fixing for mtext includes new feature: right-to-left;
We cannot simply revert some fixes: exposing a more serious bug, or breaking more features;
This issue is not serious enough for me to take immediate actions, user can workaround the issue by playing with text or alignment.
LordOfBikes wrote
Why 2.2.2?
This is what release candidates are for, find errors and fix them for the final release.
MTEXT alignment works in 2.2.0, so it was broken with new features or refactoring.
Bisecting should locate the issue easy. In case it is not easy to fix, it needs to be reverted.
Just my 2 cent.
Armin