Posted by dxli on Dec 20, 2024; 8:02pm
URL: https://forum.librecad.org/Regression-in-the-pdf-export-in-commit-from-17-10-2024-tp5725765p5725846.html

hi sand1024,

is this an issue due to uninitialized primitives?

since reading from uninitialized variables is considered undefined behavior, I suggest we initialize all primitive members in class definitions.

I have pushed a commit https://github.com/LibreCAD/LibreCAD/commit/e9dbf9415043c68b1eb5ad6fccbe9a53222f6328

In this commit, I also enabled scaling by page center for printing preview.

Another thing not actually related, I found hungarian notations help code reading. Since we only work part timely on this project, clear code is very important here.

m_ to indicate member variables;
g_ to indicate global, etc.

https://en.wikipedia.org/wiki/Hungarian_notation

https://github.com/LibreCAD/LibreCAD/commit/e9dbf9415043c68b1eb5ad6fccbe9a53222f6328

johnfound wrote

OK. I have some fix now, but not sure this is the right fix.

The problem is that during the printing (and exporting to PDF), the class RS_StaticGraphicView ignores the existing of the fields "unitFactor" and "unitFactor100" and never initialize them.

My fix is simply to set them to 1.0 and 0.01 in the constructor, but I am not very sure this is the right approach. (QG_GraphicView has more complex way for initializing these fields).

Index: librecad/src/lib/gui/rs_staticgraphicview.cpp
==================================================================
--- librecad/src/lib/gui/rs_staticgraphicview.cpp
+++ librecad/src/lib/gui/rs_staticgraphicview.cpp
@@ -44,10 +44,12 @@
 {
 	setBackground({255,255,255});
 	QSize b{5, 5};
 	if (pb) b = *pb;
 	setBorders(b.width(), b.height(), b.width(), b.height());
+    unitFactor = 1.0;
+    unitFactor100 = 0.01;
 }
 
 /**
  * @return width of widget.
  */

Nevertheless, this gives the right result in the PDF files. And during my research I have never see these fields with different values. Maybe with inch dimensions they are different, but well, I am not using inches.

Comments and directions are welcome. :)