Login  Register

Re: Regression in the pdf export in commit from 17.10.2024

Posted by sand1024 on Dec 22, 2024; 11:27am
URL: https://forum.librecad.org/Regression-in-the-pdf-export-in-commit-from-17-10-2024-tp5725765p5725866.html

Hi Dxli,

>is this an issue due to uninitialized primitives?

Well, yes and no - I simply missed that for PDF generation a bit different logic is used. Yet yes - explicit initialization by reasonable defaults is definitely a good approach.

> I found hungarian notations help code reading.

Well, I suppose the notation is rather a question of preferences.

I feel that hungarian notation may make the code more heavyweight.  Nowadays, I think syntax highlighting in IDE handles separation of fields/variables/globals/parameters better.

Yet I have no issues with using any notation. The major thing, that it should be uniform over the entire codebase for consistency. Probably it is also worth to think about some coding style for the project.