Posted by dxli on Dec 22, 2024; 4:06pm
URL: https://forum.librecad.org/Regression-in-the-pdf-export-in-commit-from-17-10-2024-tp5725765p5725867.html

hi sand1024,

To avoid undefined behaviors is more important, so even unreasonable initialization values are better, if the default value is not actually known.

For example, if unsure about an enum A, we can simply:

A a{};

Of course, make sure we don't introduce another undefined behavior here: division by zero, so if unsure for a numerical value, and it's better to initialize to 1 for a potential denominator.

For Hungarian notation, it has been long in codebase, but since you have removed them. I suggest we should choose one convention coding style, instead of relying on IDE. Again, we want the code to be as clear as possible, without assumptions on IDE.

For example, when reviewing github Pull Requests, it is not clear to see whether a variable is a member, class static, or global without reading the complete files.

Even without Hungarian notation, other examples could be followed,

Google C++ coding style: class data members with a tailing underscore; struct data members as ordinary variables;
Microsoft Win32 coding style: uses m_ prefix for data members, and g_ prefix for global;

This matter is more than just personal preferences, if leading coding styles are addressing the issue.

In addition, following the official C++ core guidelines helps.