Posted by dxli on Dec 30, 2024; 12:39am
URL: https://forum.librecad.org/Question-about-RS-EntityContainer-tp5725899p5725904.html

We may have to redesign the undo/redo and ownership.

1. Undo/redo should be able to do garbage collection (currently, all deleted entities stay, even if not reachable anymore);
2. Clear ownership, for example, requiring each entity to have a unique owning container.

johnfound wrote

dxli wrote

When reparenting, reparenting the contains meaning overriding the case 1, and enforcing for case 2.

The reparenting does not affects the ownership at all. It is simply a back pointer in the tree. The forward traversing of the tree is by following items from the QList entities, the back traversing is by following the parent fields.

So, should reparenting break the back links of the tree?