Posted by johnfound on Dec 30, 2024; 7:54pm
URL: https://forum.librecad.org/Question-about-RS-EntityContainer-tp5725899p5725914.html

Well, please, don't tell general tales.

The "virtual" reparent is overridden only in RS_EntityContainer and wrongly!

And there can't be any correct logic, other than "parent = p". Setting the childrens parent to the new parent is wrong, regardless of the rationale staying behind it. BTW, I suspect that the RS_EntityContainer is a result of copy-paste programming. Compare yourself:

void RS_EntityContainer::reparent(RS_EntityContainer *parent) {
    RS_Entity::reparent(parent);

    // All sub-entities:

    for (auto e: std::as_const(entities)) {
        e->reparent(parent);
    }
}

void RS_EntityContainer::setVisible(bool v) {
    RS_Entity::setVisible(v);

    // All sub-entities:

    for (auto e: std::as_const(entities)) {
        e->setVisible(v);
    }
}