Posted by sand1024 on Feb 07, 2025; 3:23pm
URL: https://forum.librecad.org/I-need-user-input-in-the-actions-tp5726401p5726403.html

hm... no sure how that might be addressed right now.

Actually, it's responsibility of the action to handle user's input according to the current actions' state.
State is important, since, for example, coordinates input in different states may mean complete different things (think about start/end point of the line).

Therefore, the only way to support processing is just expand actions and ensure that they are fully controlled via cmd line.

I've planned to review cmd support later, so that will be revised, of course.

From the other side  - I'm really not sure that this is promising idea to rely on the current actions implementations.  Of course, it may deliver some shortcuts, but in longer prospecteve - will be deliver maintenance and support hell.

For sure, it might be that some useful logic currently is incorporated directly into actions, but even if it so - it's more practical to identify it and move to some reusable code (that might be used both by actions and scripting).

Just to illustrate the above:

Consider "rotate" action. There are lot's of code for handling user's input, generation of preview, controlling states, mouse etc.  

Obviously, all that code is not relevant for the scripting.

For the scripting view - you just have to provide the user with possibility to gather necessary parameters (like rotation angle), select entities (here I'm really not sure how to select particular entities via scripting) - and invoke rotate operation.

All this logic may be completely decoupled from actions and be performed on scripting part, of course.

However, the actual process of modification (i.e. rotation) is quite universal - and it may be extracted to something like src/lib/modification/RS_Modification.h (as well src/lib/modification/RS_Creation etc).
Please take a look to them - probably methods from there will be helpful for your purposes.

P.S
> What I noticed: I modified a polyline (arc).
> It then had a hole between the arc and the last segment.

Could you please expand on reproducing this and share a sample DXF with such behavior?

P.P.S there are includes like

#include "intern/qc_actiongetpoint.h"
#include "intern/qc_actiongetcorner.h"
#include "intern/qc_actionentsel.h"

But it seems that there is no "intern" directory, please make sure that you didn't forget to commit it too.