LibreCAD › LibreCAD-dev

potential memory leak in dxfrw

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

dxli

Dec 31, 2013; 8:54pm

potential memory leak in dxfrw

1985 posts

This post was updated on Jan 01, 2014; 3:42am.

Rallaz,

can you review my fixes:

https://github.com/LibreCAD/LibreCAD/commit/19c6b9e3759e6ecc36bbb935d7d637fa1ee24eda

I feel more fixes similar are still out there.

more similar fixes in my branch:

https://github.com/dxli/LibreCAD

Rallaz

Jan 02, 2014; 10:33am

Re: potential memory leak in dxfrw

395 posts

I will do it,

But, for compability of older systems and programs I prefer that he does not have std11 code,
because libdxfrw may be useful for others open source programs and we could have more feedback.

Cheers,
Rallaz

dxli

Jan 08, 2014; 5:11pm

Re: potential memory leak in dxfrw

1985 posts

Hi Rallaz,

right now, pretty much every platform supports c++11, so I'm not so worried.

I am not sure whether about the memory leak issue itself:

1, is there actually a memory leak?

2, is the smart pointer a proper fix, given a "yes" answer to question 1?

Thanks,

Dongxu

On Thu, Jan 2, 2014 at 5:33 AM, Rallaz [via LibreCAD] <[hidden email]> wrote:

I will do it,

But, for compability of older systems and programs I prefer that he does not have std11 code,
because libdxfrw may be useful for others open source programs and we could have more feedback.

Cheers,
Rallaz

If you reply to this email, your message will be added to the discussion below:

http://forum.librecad.org/potential-memory-leak-in-dxfrw-tp5709327p5709334.html

To start a new topic under LibreCAD-dev, email [hidden email]
To unsubscribe from LibreCAD-dev, click here.
NAML

--
Dongxu Li, Ph.D.
www.librecad.org

dxli

Jan 09, 2014; 3:50pm

Re: potential memory leak in dxfrw

1985 posts

Hi Rallaz,

I have reverted my changes, because I found it causes segfault with dimensions.

This requires a 2.0.2 release soon.

dxli

Rallaz

Jan 10, 2014; 11:48am

Re: potential memory leak in dxfrw

395 posts

Hi Dongxu,

The memory leak is present, at least, in drw_variant and drw_header.

I send two commits fixing it.

I made some test in linux and read/write process are OK.

May be a read/write tests in win & osX are required.

Cheers